Road Gradient srt patch

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Road Gradient srt patch

Giovanni Zilli
Hello there!
This is my first ever svn patch, so please be patient with me :)
It is based on r4980, and it will add road gradient in percentage.

In this Youtube subtitles you can see a sample:

Thank you!

Giovanni

------------------------------------------------------------------------------

_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code

gpsbabel_slope_gradient.diff (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Road Gradient srt patch

Robert Lipe-4
Welcome and thanx!

At a glance, this seems pretty reasonable.  I'll make a few whitespace changes, use %% instead of %c...37, and improve handling of unknown altitudes, but it seems pretty good to me.  I can do patient. :-)

If you can offer a sentence or two for the doc (that .xml file you edited) and a simple file (it can be three points or something) that exercises this and related formatting options in the test suite, that would be helpful, but I won't block on it.

RJL

On Wed, Jun 17, 2015 at 1:43 PM, Giovanni Zilli <[hidden email]> wrote:
Hello there!
This is my first ever svn patch, so please be patient with me :)
It is based on r4980, and it will add road gradient in percentage.

In this Youtube subtitles you can see a sample:

Thank you!

Giovanni

------------------------------------------------------------------------------

_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code



------------------------------------------------------------------------------

_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Road Gradient srt patch

Robert Lipe-4
Submitted as revision 4999 with minor tweaks.  Please do follow up with those doc improvements and testo cases, please.


On Wed, Jun 17, 2015 at 3:09 PM, Robert Lipe <[hidden email]> wrote:
Welcome and thanx!

At a glance, this seems pretty reasonable.  I'll make a few whitespace changes, use %% instead of %c...37, and improve handling of unknown altitudes, but it seems pretty good to me.  I can do patient. :-)

If you can offer a sentence or two for the doc (that .xml file you edited) and a simple file (it can be three points or something) that exercises this and related formatting options in the test suite, that would be helpful, but I won't block on it.

RJL

On Wed, Jun 17, 2015 at 1:43 PM, Giovanni Zilli <[hidden email]> wrote:
Hello there!
This is my first ever svn patch, so please be patient with me :)
It is based on r4980, and it will add road gradient in percentage.

In this Youtube subtitles you can see a sample:

Thank you!

Giovanni

------------------------------------------------------------------------------

_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code




------------------------------------------------------------------------------

_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code
Loading...