[PATCH] google.cc segfault

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] google.cc segfault

Ralf Horstmann
Hi,

afl found a crash in google.cc. Minimized input and patch is attached.
To reproduce:

gpsbabel -i google -f google1.xml

Cheers,
Ralf


------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code

gpsbabel-google-fix.patch (838 bytes) Download Attachment
google1.xml (107 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] google.cc segfault

Robert Lipe-4
Thanx.  Committed in 4955.

That reader really is fragile.  If we could raise the floor to Qt 5 (?) QJsonDocument would make things less grubby. 

Are these real world problems, or is this AFL at work?

On Sat, Dec 20, 2014 at 5:30 PM, Ralf Horstmann <[hidden email]> wrote:
Hi,

afl found a crash in google.cc. Minimized input and patch is attached.
To reproduce:

gpsbabel -i google -f google1.xml

Cheers,
Ralf


------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code


------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] google.cc segfault

Ralf Horstmann
This was all afl and little bit of valgrind.

Btw, there was another bug exposed in QXmlStreamReader that affects gpsbabel as
well:

https://bugreports.qt-project.org/browse/QTBUG-43513

* Robert Lipe <[hidden email]> [2014-12-22 20:37]:

> Thanx.  Committed in 4955.
>
> That reader really is fragile.  If we could raise the floor to Qt 5
> (?) QJsonDocument would make things less grubby.
>
> Are these real world problems, or is this AFL at work?
>
> On Sat, Dec 20, 2014 at 5:30 PM, Ralf Horstmann <[hidden email]>
> wrote:
> >
> > Hi,
> >
> > afl found a crash in google.cc. Minimized input and patch is attached.
> > To reproduce:
> >
> > gpsbabel -i google -f google1.xml
> >
> > Cheers,
> > Ralf

------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code