Github pull request

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Github pull request

Mykhaylo Yehorov
Hi,

I've just created a pull request to gpsbabel/gpsbabel repository on github.
https://github.com/gpsbabel/gpsbabel/pull/50

Could anybody review and merge it?

--
Mykhaylo Yehorov

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code
Reply | Threaded
Open this post in threaded view
|

Re: Github pull request

Robert Lipe-4
Man, that code is just plain hard to read. Thanx for pushing through.  I'll look into what's up with our build system.

The mtk module is used on a trainload of different models and we've had problems in the past where we'll do something for one device and it'll break others.  You probably don't have a whole lot to test on, but can you speculate on how well this is likely to work on other devices? If there is question, should we make it an option to use the slower, but better tested path?

Could others with MTK devices, please pull that into your trees and confirm success?

RJL

On Mon, Aug 8, 2016 at 4:13 PM, Mykhaylo Yehorov <[hidden email]> wrote:
Hi,

I've just created a pull request to gpsbabel/gpsbabel repository on github.
https://github.com/gpsbabel/gpsbabel/pull/50

Could anybody review and merge it?

--
Mykhaylo Yehorov

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code



------------------------------------------------------------------------------

_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code
Reply | Threaded
Open this post in threaded view
|

Re: Github pull request

tsteven4-2

Somehow this pull request was triggering the git pager.  I fixed our build script to avoid this (https://github.com/gpsbabel/gpsbabel/commit/15131349fd7318c7eaee92a82b24071971750d68).  Regression is running now (https://travis-ci.org/gpsbabel/gpsbabel/jobs/150757821).



On 8/16/2016 12:45 PM, Robert Lipe wrote:
Man, that code is just plain hard to read. Thanx for pushing through.  I'll look into what's up with our build system.

The mtk module is used on a trainload of different models and we've had problems in the past where we'll do something for one device and it'll break others.  You probably don't have a whole lot to test on, but can you speculate on how well this is likely to work on other devices? If there is question, should we make it an option to use the slower, but better tested path?

Could others with MTK devices, please pull that into your trees and confirm success?

RJL

On Mon, Aug 8, 2016 at 4:13 PM, Mykhaylo Yehorov <[hidden email]> wrote:
Hi,

I've just created a pull request to gpsbabel/gpsbabel repository on github.
https://github.com/gpsbabel/gpsbabel/pull/50

Could anybody review and merge it?

--
Mykhaylo Yehorov

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code




------------------------------------------------------------------------------


_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code


------------------------------------------------------------------------------

_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code
Reply | Threaded
Open this post in threaded view
|

Re: Github pull request

Robert Lipe-4
Excellent find. Thank you!

On Wed, Aug 17, 2016 at 8:20 AM, tsteven4 <[hidden email]> wrote:

Somehow this pull request was triggering the git pager.  I fixed our build script to avoid this (https://github.com/gpsbabel/gpsbabel/commit/15131349fd7318c7eaee92a82b24071971750d68).  Regression is running now (https://travis-ci.org/gpsbabel/gpsbabel/jobs/150757821).



On 8/16/2016 12:45 PM, Robert Lipe wrote:
Man, that code is just plain hard to read. Thanx for pushing through.  I'll look into what's up with our build system.

The mtk module is used on a trainload of different models and we've had problems in the past where we'll do something for one device and it'll break others.  You probably don't have a whole lot to test on, but can you speculate on how well this is likely to work on other devices? If there is question, should we make it an option to use the slower, but better tested path?

Could others with MTK devices, please pull that into your trees and confirm success?

RJL

On Mon, Aug 8, 2016 at 4:13 PM, Mykhaylo Yehorov <[hidden email]> wrote:
Hi,

I've just created a pull request to gpsbabel/gpsbabel repository on github.
https://github.com/gpsbabel/gpsbabel/pull/50

Could anybody review and merge it?

--
Mykhaylo Yehorov

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code




------------------------------------------------------------------------------


_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code



------------------------------------------------------------------------------

_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code
Reply | Threaded
Open this post in threaded view
|

Re: Github pull request

Mykhaylo Yehorov
In reply to this post by Robert Lipe-4

In new implementation data is requested with 1K blocks by default. The same size is used in current implementation.
I believe the patch shouldn't affect any users if the block_size option isn't specified when they invoke gbsbabel.

On Tue, Aug 16, 2016 at 9:45 PM, Robert Lipe <[hidden email]> wrote:
Man, that code is just plain hard to read. Thanx for pushing through.  I'll look into what's up with our build system.

The mtk module is used on a trainload of different models and we've had problems in the past where we'll do something for one device and it'll break others.  You probably don't have a whole lot to test on, but can you speculate on how well this is likely to work on other devices? If there is question, should we make it an option to use the slower, but better tested path?

Could others with MTK devices, please pull that into your trees and confirm success?

RJL

On Mon, Aug 8, 2016 at 4:13 PM, Mykhaylo Yehorov <[hidden email]> wrote:
Hi,

I've just created a pull request to gpsbabel/gpsbabel repository on github.
https://github.com/gpsbabel/gpsbabel/pull/50

Could anybody review and merge it?

--
Mykhaylo Yehorov

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code





--
Mykhaylo Yehorov

------------------------------------------------------------------------------

_______________________________________________
Gpsbabel-code mailing list  http://www.gpsbabel.org
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gpsbabel-code