Building 1.5.3 : paths, zlib

classic Classic list List threaded Threaded
9 messages Options
lj
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Building 1.5.3 : paths, zlib

lj
Just 2 minor points about building gpsbabel-1.5.3 from source:

First, unpacking gpsbabel-1.5.3.tar.gz does not create a top-level
directory gpsbabel-1.5.3 (as it did with 1.5.2 and other software does).
The top level (README*, configure, source files, etc) just end up in the
current directory. This is unexpected, and I assume it wasn't intentional.

Second, gpsbabel-1.5.3 failed to build for me with --with-zlib=system, even
though I have the same version zlib-1.2.8 installed on my Linux system. I
was able to build 1.5.2 with --with-zlib=system, but 1.5.3 gets a number of
link errors like this: "src/core/ziparchive.o: In function
`ZipArchive::Close()': ziparchive.cc:49: undefined reference to
`zipClose'". It probably isn't worth looking into, as 1.5.3 builds fine
using the included zlib. But I suspect something changed in 1.5.3
("minizip" usage maybe?) that makes GPSBabel no longer compatible with
'stock' zlib, and if so perhaps --with-zlib=system should be removed from
configure.


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Gpsbabel-misc mailing list http://www.gpsbabel.org
[hidden email]
To unsubscribe, change list options, or see archives, visit:
https://lists.sourceforge.net/lists/listinfo/gpsbabel-misc
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Building 1.5.3 : paths, zlib

Robert Lipe-4
First, unpacking gpsbabel-1.5.3.tar.gz does not create a top-level
directory gpsbabel-1.5.3 (as it did with 1.5.2 and other software does).

Please tweak release the release-tarball target in Makefile.in and send a pull request. The solution might involve something like--prefix=gpsbabel-$(VERSIOND) 
 
The top level (README*, configure, source files, etc) just end up in the
current directory. This is unexpected, and I assume it wasn't intentional.

A side effect from moving to Github.
 
Second, gpsbabel-1.5.3 failed to build for me with --with-zlib=system, even
though I have the same version zlib-1.2.8 installed on my Linux system. I

zlib=system isn't something I personally care very much about.  (I can't say I'm a fan of building against whatever random version of a third party lib happens to be on your system)  Bernhard and other Linux maintainers may wish to look into this.

using the included zlib. But I suspect something changed in 1.5.3
("minizip" usage maybe?)

Between kmz and ggz, I think that minizip is more on the way in than the way out. You're correct that would have been new in 1.5.3

 
that makes GPSBabel no longer compatible with
'stock' zlib, and if so perhaps --with-zlib=system should be removed from
configure.


 Personaly, I'd remove --with-zlib=system before debugging it. My days of caring about duplication of a library measured in tens of kilobytes are over. I get there are theoretical security and VM concerns, but for an app like GPSBabel, I just can't get too worked about them.

Please do address the release-tarball issue, though.

RJL

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Gpsbabel-misc mailing list http://www.gpsbabel.org
[hidden email]
To unsubscribe, change list options, or see archives, visit:
https://lists.sourceforge.net/lists/listinfo/gpsbabel-misc
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Building 1.5.3 : paths, zlib

tsteven4-2
In reply to this post by lj
Also note that we had to patch zlib to fix a bug that manifests itself
on some platforms.
see
https://github.com/gpsbabel/gpsbabel/blob/master/zlib/README.gpsbabel
https://github.com/gpsbabel/gpsbabel/blob/master/zlib/gzlib.patch

I was not able to ever reach any upstream maintainer for zlib, so this
patch remains local to gpsbabel.

On 1/10/2016 7:12 PM, lj wrote:

> Just 2 minor points about building gpsbabel-1.5.3 from source:
>
> First, unpacking gpsbabel-1.5.3.tar.gz does not create a top-level
> directory gpsbabel-1.5.3 (as it did with 1.5.2 and other software does).
> The top level (README*, configure, source files, etc) just end up in the
> current directory. This is unexpected, and I assume it wasn't intentional.
>
> Second, gpsbabel-1.5.3 failed to build for me with --with-zlib=system, even
> though I have the same version zlib-1.2.8 installed on my Linux system. I
> was able to build 1.5.2 with --with-zlib=system, but 1.5.3 gets a number of
> link errors like this: "src/core/ziparchive.o: In function
> `ZipArchive::Close()': ziparchive.cc:49: undefined reference to
> `zipClose'". It probably isn't worth looking into, as 1.5.3 builds fine
> using the included zlib. But I suspect something changed in 1.5.3
> ("minizip" usage maybe?) that makes GPSBabel no longer compatible with
> 'stock' zlib, and if so perhaps --with-zlib=system should be removed from
> configure.
>
>
> ------------------------------------------------------------------------------
> Site24x7 APM Insight: Get Deep Visibility into Application Performance
> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
> Monitor end-to-end web transactions and take corrective actions now
> Troubleshoot faster and improve end-user experience. Signup Now!
> http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
> _______________________________________________
> Gpsbabel-misc mailing list http://www.gpsbabel.org
> [hidden email]
> To unsubscribe, change list options, or see archives, visit:
> https://lists.sourceforge.net/lists/listinfo/gpsbabel-misc


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Gpsbabel-misc mailing list http://www.gpsbabel.org
[hidden email]
To unsubscribe, change list options, or see archives, visit:
https://lists.sourceforge.net/lists/listinfo/gpsbabel-misc
lj
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Building 1.5.3 : paths, zlib

lj
In reply to this post by Robert Lipe-4
Robert Lipe wrote:
> Please tweak release the release-tarball target in Makefile.in and send a pull
> request. The solution might involve something like--prefix=gpsbabel-$(VERSIOND)

In Makefile.in, release-tarball looks OK to me, as far as the paths. It
uses the release-sourcecheck target to build the staging area. But
release-sourcecheck does SVN exports from googlecode, and you're not there
anymore are you? So I assume that release-tarball target wasn't actually
used to package 1.5.3... something else was?



------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Gpsbabel-misc mailing list http://www.gpsbabel.org
[hidden email]
To unsubscribe, change list options, or see archives, visit:
https://lists.sourceforge.net/lists/listinfo/gpsbabel-misc
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Building 1.5.3 : paths, zlib

Robert Lipe-4
It's possible that I made the tarball before committing. (I don't always push untested code...)  https://github.com/gpsbabel/gpsbabel/commits/master/Makefile.in

On Mon, Jan 11, 2016 at 5:18 PM, lj <[hidden email]> wrote:
Robert Lipe wrote:
> Please tweak release the release-tarball target in Makefile.in and send a pull
> request. The solution might involve something like--prefix=gpsbabel-$(VERSIOND)

In Makefile.in, release-tarball looks OK to me, as far as the paths. It
uses the release-sourcecheck target to build the staging area. But
release-sourcecheck does SVN exports from googlecode, and you're not there
anymore are you? So I assume that release-tarball target wasn't actually
used to package 1.5.3... something else was?



------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Gpsbabel-misc mailing list http://www.gpsbabel.org
[hidden email]
To unsubscribe, change list options, or see archives, visit:
https://lists.sourceforge.net/lists/listinfo/gpsbabel-misc


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Gpsbabel-misc mailing list http://www.gpsbabel.org
[hidden email]
To unsubscribe, change list options, or see archives, visit:
https://lists.sourceforge.net/lists/listinfo/gpsbabel-misc
lj
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Building 1.5.3 : paths, zlib

lj
Robert Lipe wrote:
> It's possible that I made the tarball before committing.

OK sorry I should have checked your git repository for the newer Makefile.in.
Yes I think you are correct, the 'git' command needs --prefix just as you
said but also you need a trailing slash. See below. However I don't have
any way to test this for you.

--- Makefile.in.orig    2016-01-11 19:08:43.233407382 -0500
+++ Makefile.in 2016-01-11 19:18:00.014377883 -0500
@@ -322,7 +322,7 @@
  #  rm -fr gpsbabel-$(VERSIOND)
     # cp -ap internal_styles.cc gpsbabel-$(VERSIOND)/
     # tar czf /tmp/gpsbabel-$(VERSIOND).tar.gz gpsbabel-$(VERSIOND)
-   git archive HEAD | gzip > /tmp/gpsbabel-$(VERSIOND).tar.gz
+   git --prefix=gpsbabel-$(VERSIOND)/ archive HEAD | gzip > /tmp/gpsbabel-$(VERSIOND).tar.gz
     gb_upload /tmp/gpsbabel-$(VERSIOND).tar.gz
  #  cd /tmp ; tar xzf gpsbabel-$(VERSIOND).tar.gz


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Gpsbabel-misc mailing list http://www.gpsbabel.org
[hidden email]
To unsubscribe, change list options, or see archives, visit:
https://lists.sourceforge.net/lists/listinfo/gpsbabel-misc
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Building 1.5.3 : paths, zlib

Robert Lipe-4
If that command gets you a /tmp/gpsbabel-WHATEVER that you feel better reflects what we should have, that test is complete.

Bonus points if you can figure out how to ensure the timestamps in the tarball are ordered so that you don't need autoconf or gperf or whatever to regenerate generated files just because of timestamp ordering.  the release-sourcecheck target used to do that, but making a tarball, extracting it, touching a few files, then putting it back into a tarball seemed kind of quaint.


Yes, the following gb_upload will fail for you, but not enough to make your test invalid.

RJL

On Mon, Jan 11, 2016 at 6:23 PM, lj <[hidden email]> wrote:
Robert Lipe wrote:
> It's possible that I made the tarball before committing.

OK sorry I should have checked your git repository for the newer Makefile.in.
Yes I think you are correct, the 'git' command needs --prefix just as you
said but also you need a trailing slash. See below. However I don't have
any way to test this for you.

--- Makefile.in.orig    2016-01-11 19:08:43.233407382 -0500
+++ Makefile.in 2016-01-11 19:18:00.014377883 -0500
@@ -322,7 +322,7 @@
  #  rm -fr gpsbabel-$(VERSIOND)
     # cp -ap internal_styles.cc gpsbabel-$(VERSIOND)/
     # tar czf /tmp/gpsbabel-$(VERSIOND).tar.gz gpsbabel-$(VERSIOND)
-   git archive HEAD | gzip > /tmp/gpsbabel-$(VERSIOND).tar.gz
+   git --prefix=gpsbabel-$(VERSIOND)/ archive HEAD | gzip > /tmp/gpsbabel-$(VERSIOND).tar.gz
     gb_upload /tmp/gpsbabel-$(VERSIOND).tar.gz
  #  cd /tmp ; tar xzf gpsbabel-$(VERSIOND).tar.gz


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Gpsbabel-misc mailing list http://www.gpsbabel.org
[hidden email]
To unsubscribe, change list options, or see archives, visit:
https://lists.sourceforge.net/lists/listinfo/gpsbabel-misc


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Gpsbabel-misc mailing list http://www.gpsbabel.org
[hidden email]
To unsubscribe, change list options, or see archives, visit:
https://lists.sourceforge.net/lists/listinfo/gpsbabel-misc
lj
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Building 1.5.3 : paths, zlib

lj
Robert Lipe wrote:

> If that command gets you a /tmp/gpsbabel-WHATEVER that you feel better
> reflects what we should have, that test is complete.
>
> Bonus points if you can figure out how to ensure the timestamps in the tarball
> are ordered so that you don't need autoconf or gperf or whatever to regenerate
> generated files just because of timestamp ordering.  the release-sourcecheck
> target used to do that, but making a tarball, extracting it, touching a few
> files, then putting it back into a tarball seemed kind of quaint.
>
>
> Yes, the following gb_upload will fail for you, but not enough to make your
> test invalid.

No, I think there is a misunderstanding here. I want to help, but I've never
used git (I have a github account, but I've only used it for tickets on
another project). I didn't test "make release-tarball" at all because I don't
know how and I don't even have the git package on this PC. Sorry if I implied
otherwise.



------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Gpsbabel-misc mailing list http://www.gpsbabel.org
[hidden email]
To unsubscribe, change list options, or see archives, visit:
https://lists.sourceforge.net/lists/listinfo/gpsbabel-misc
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Building 1.5.3 : paths, zlib

Robert Lipe-4

On Mon, Jan 11, 2016 at 7:54 PM, lj <[hidden email]> wrote:
Robert Lipe wrote:
> If that command gets you a /tmp/gpsbabel-WHATEVER that you feel better
> reflects what we should have, that test is complete.
>
> Bonus points if you can figure out how to ensure the timestamps in the tarball
> are ordered so that you don't need autoconf or gperf or whatever to regenerate
> generated files just because of timestamp ordering.  the release-sourcecheck
> target used to do that, but making a tarball, extracting it, touching a few
> files, then putting it back into a tarball seemed kind of quaint.
>
>
> Yes, the following gb_upload will fail for you, but not enough to make your
> test invalid.

No, I think there is a misunderstanding here. I want to help, but I've never
used git (I have a github account, but I've only used it for tickets on
another project). I didn't test "make release-tarball" at all because I don't
know how and I don't even have the git package on this PC. Sorry if I implied
otherwise.



------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Gpsbabel-misc mailing list http://www.gpsbabel.org
[hidden email]
To unsubscribe, change list options, or see archives, visit:
https://lists.sourceforge.net/lists/listinfo/gpsbabel-misc


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Gpsbabel-misc mailing list http://www.gpsbabel.org
[hidden email]
To unsubscribe, change list options, or see archives, visit:
https://lists.sourceforge.net/lists/listinfo/gpsbabel-misc
Loading...